Repository navigation
fix(temporal): connect to the namespace in TEMPORAL_NAMESPACE - #571
Closed
declan-scale wants to merge 2 commits into
Closed
declan-scale wants to merge 2 commits into
declan-scale wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Temporal clients created by the SDK now connect to the namespace in
TEMPORAL_NAMESPACEwhen it is set. Without it, they connect as before.Why
The
agentex-agentchart setsTEMPORAL_NAMESPACEfromglobal.temporal.namespaceon both the ACP and the temporal-worker Deployments, but the SDK never read it. Every agent therefore ran in Temporal'sdefaultnamespace, whatever the deployment configured. On a server with namespace-scoped authorization, an agent whose identity holds a role only for its own namespace is denied indefault.How
connect_temporal_clientis the single connect path for the ACP client and the worker. It addsnamespacefromTEMPORAL_NAMESPACEto the connect options unless the caller already passed one. Anonymous and Workload Identity connections both use it.Verification
Client.connecton the anonymous and the authenticated path, and an explicit namespace is kept. Both fail on the previous release.TEMPORAL_NAMESPACEand still asserts the exact legacy connect arguments.TEMPORAL_NAMESPACEset, both the ACP client and the worker builders pass it toClient.connect; without it, neither passes a namespace.tests/lib/test_temporal_auth.py,test_temporal_utils.py,test_agentex_worker.pyandtest_payload_codec.py: 70 passed. Ruff check and format pass.What could go wrong
A deployment that sets
TEMPORAL_NAMESPACEto a namespace other than the one its workflows live in now moves to that namespace. Chart releases defaultglobal.temporal.namespacetodefault, so deployments that never set it are unchanged.This PR carries the commits of #570 from a branch in this repository. The fork PR gets no repository secrets, so the tutorial tests fail there with no OpenAI API key.
🤖 Generated with Claude Code


Confidence Score: 5/5
This PR appears safe to merge.Summary
Temporal clients now use
TEMPORAL_NAMESPACEwhen the caller has not suppliednamespace.No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "test(temporal): clear TEMPORAL_NAMESPACE..." · Reviewed by Greptile